Add many ensureStillAliveHere scopes for good measure - #1649
Merged
justinmichaud merged 1 commit intoAug 1, 2026
Merged
Conversation
Author
|
Let's land this anyway, since it can't hurt, but I was not able to find an example of this actually being needed in the current production binary. |
Author
|
This patch has zero risk of breaking runtime, so I will land it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See WebKit/WebKit#62985
This pattern crops up a bunch:
JSCell* a = ...
call(a->something())
So a can die before call, and that is completely valid, but
something() returns a pointer that is kept alive by a.
This patch fixes a bunch of these cases.
0822b5b